HaloDAO security record

One or more declarations do not conform to the [Solidity style guide](https://solidity.readthedocs.io/en/v0.7.3/style-guide.html#naming-conventions) with regards to its naming convention. Particularly: - `camelCase`: Should be applied to function names, argument names, local and state variable names, modifiers - `UPPER_CASE`: Should be applied to `constant` variables - `CapWords`: Should be applied to contract names, struct names, event names and enums File: contracts/HLPPriceFeedOracle.sol (Line 12) ```solidity contract hlpPriceFeedOracle { ``` - Contract `hlpPriceFeedOracle` is not in `CapWords`. --- File: contracts/HLPPriceFeedOracle.sol (Line 7) ```solidity interface hlpContract { ``` - Contract `hlpContract` is not in `CapWords`. --- File: contracts/PriceFeed.sol (Line 6) ```solidity contract fxPriceFeed { ``` - Contract `fxPriceFeed` is not in `CapWords`.

The functions which are never called internally within the contract should have external visibility for gas optimization. File: contracts/HLPPriceFeedOracle.sol (Line 33, Contract `hlpPriceFeedOracle`) ```solidity function latestAnswer() public view returns (int256) { ``` --- File: contracts/PriceFeed.sol (Line 25, Contract `fxPriceFeed`) ```solidity function latestAnswer() public view returns (int256) { ```

Currently, the data is being queried from chainlink as per the testing files. Chainlink provides a reliable manipulation resistant price feed for blockchain data. It should be noted that if the data is queried from another oracle such as a liquidity pool the data may no longer be manipulation resistant.

The linked variables assigned in the constructor can be declared as `immutable`. Immutable state variables can be assigned during contract creation but will remain constant throughout the lifetime of a deployed contract. A big advantage of immutable variables is that reading them is significantly cheaper than reading from regular state variables since they will not be stored in storage.