CertiK reviewed Venus Protocol (Swipe Venus Protocol) on 16 Dec 2020: 43 findings, 0 critical; 21 marked fixed, 22 open.
Report hosted on skynet.certik.com.
Trustblock does not review code.
Statuses are the security firm’s own, from its report.
| Severity | Open | Acknowledged | Fixed |
|---|---|---|---|
| Critical | 0 | 0 | 0 |
| High | 0 | 0 | 0 |
| Medium | 0 | 0 | 0 |
| Low | 22 | 0 | 21 |
The `require` statements on the aforementioned lines can be substituted with a `modifier` to increase the legibility of the codebase and to avoid code duplciation.
The `require` statements on the aforementioned lines can be substituted with a `modifier` to increase the legibility of the codebase and to avoid code duplication.
The `requrie` statement on the aforementioned lines can be substituted with a `modifier` to increase the legibility of the codebase and also to avoid code duplication.
The aforementioned lines perform comparison with a literal false which is unnecessary and can be replaced with the negation of expression f.e `!expression` .
The aforementioned lines perform comparison with a literal `true` which is unnecessary and can be replaced with the expression itself.
The comment on the aforementioned line refers the variable following it as `borrow index` whereas it is infact a `supply index` .
The linked function is declared as public , contains array function arguments and is not invoked in any of the contract's contained within the project's scope.
The comment on the aforementioned line has incorrect grammar for the word borrow .
The structure of the codebase does not conform to the official Solidity style guide of `v0.5.16` . The style guide can be found here https://docs.soliditylang.org/en/v0.5.16/style-guide.html#or der-of-functions.
The comparison `msg.sender == address(0)` is ineffectual as it will never evaluate to `true` because `msg.sender` can never have a value of `address(0)` .
The comparison `pendingVAIControllerImplementation == address(0)` on the aforementioned line is ineffectual as it will never evaluate to `true` . When the first comparison evaluates to `false` in the event of `pendingVAIControllerImplementation` being equal to `msg.sender` then the aforementioned comparison will always evaluate to `false` as `msg.sender` can never can be equal to `address(0)` .
The aforementioned line perform unnecessary storage read as the same value can be read from a local variable of `newCloseFactorMantissa`.
The storage read on the aforementioned line is unnecessary as the same value is available through local variable `newPauseGuardian`.
The type of function parameter `vToken` on `L1021` can be changed to VToken to avoid unnecessary casting to address type and save gas cost associated with it.
The functions on the aforementioned lines perform same functionality with only difference being one of them provides a public interface while the other one is an internal implementation.
The linked greater-than comparisons with zero compare variables that are restrained to the non-negative integer range, meaning that the comparator can be changed to an inequality one which is more gas efficient.
The local variable on the aforementioned line is only used once in the code and its usage can be replaced with initialization part of the statement on `L135` to save gas cost associated with local variable declaration.
The linked statements do not affect the functionality of the codebase and appear to be either leftovers from test code or older functionality.
All variable types within Solidity are initialized to their default "empty" value, which is usually their zeroed out representation. Particularly: - uint / int : All uint and int variable types are initialized at 0 - address : All address types are initialized to address(0) - byte : All byte types are initialized to their byte(0) representation - bool : All bool types are initialized to false - ContractType : All contract types (i.e. for a given contract ERC20{} its contract type is ERC20) are initialized to their zeroed out address (i.e. for a given contract ERC20{} its default value is ERC20(address(0))) - struct : All struct types are initialized with all their members zeroed out according to this table
The function call on the aforementioned line returns an error code which is not checked. The problem will arise if the `vaiController` is not set in the `comptroller` contract then the function call will still be treated as successful but the mint amount would not have been set.
The function call on the aforementioned line returns an error code which is not checked. The problem will arise if the `vaiController` is not set in the `comptroller` contract then the function call will still be treated as successful but the mint amount would not have been set.
The report names a repository or files. Open the report to see its scope.
Repository and files the report names (12)
1,045 projects reviewed · 1,376 reports · latest May 2025
See CertiK’s auditsSomething wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.
Tell us