LiveArtX-Ⅱ

The order of external calls and transfers and storage variable updates should follow the check-effect-interaction pattern. ### External call(s) ```solidity=147 _transfer(beneficiary, msg.value); ``` * This function call executes the following external call(s). * In `MetaMorphic._transfer`, * `(success) = _address.call{value: _amount}()` ### State variables written after the call(s) ```solidity=151 mintedAmount1 = mintedAmount1.add(mintedAmount); ``` ```solidity=152 mintedAmounts1[account] = mintedAmount.add(amount); ``` --- ### External call(s) ```solidity=175 _transfer(beneficiary, msg.value); ``` * This function call executes the following external call(s). * In `MetaMorphic._transfer`, * `(success) = _address.call{value: _amount}()` ### State variables written after the call(s) ```solidity=179 mintedAmount2 = mintedAmount2.add(mintedAmount); ``` ```solidity=180 mintedAmounts2[account] = mintedAmount.add(amount); ```

In function `mint1()`, users can overpay for a given amount of tokens since the only check is the following: ```solidity if (msg.value < amount.mul(price1)) { revert InsufficientETH(); } ``` The same issue is present for function `mint2()`.