Quantstamp reviewed Solv Protocol (Solv Protocol- Vault Guardian) on 25 Mar 2024: 11 findings, 0 critical; 7 marked fixed, 4 acknowledged; 1 more marked mitigated.
Report hosted on certificate.quantstamp.com.
Trustblock does not review code.
Statuses are the security firm’s own, from its report.
| Severity | Open | Acknowledged | Fixed | Mitigated |
|---|---|---|---|---|
| Critical | 0 | 0 | 0 | 0 |
| High | 0 | 0 | 3 | 0 |
| Medium | 0 | 0 | 1 | 1 |
| Low | 0 | 4 | 3 | 0 |
Marked Informational by the firm. Not counted as findings.
Currently, some of the ACL implementations that allow token whitelisting only allow them to be added via `_addTokenWhitelist()` during deployment. There is no way to modify this token whitelist following deployment. This could be an issue if one of the tokens becomes compromised or is no longer supported, or, if there are additional tokens that would want to be supported by Solv in the future.
"Dead" code refers to code which is never executed and hence makes no impact on the final result of running a program. Dead code raises a concern, since either the code is unnecessary or the necessary code's results were ignored. There is dead code in the following places: 1. `ETH` in `ERC20ApproveAuthorization` 2. `ETH` in `ERC20TransferAuthorization` 3. `GLP_REWAED_ROUTER` in `GMXV1AuthorizationACL` 4. `repayWithBalance()` in `SolvOpenEndFundAuthorizationACL`
Currently, the `SolvOpenEndFundAuthorization` does not initialize with support for the `repayWithBalance()` function despite that function being included in the `SolvOpenEndFundAuthorizationACL`.
The owner of the contracts can call `transferGovernance()` to transfer the ownership to a new address. If an uncontrollable address is accidentally provided as the new owner address, then the contract will no longer have an active owner, and functions with the `onlyGovernor()` modifier can no longer be executed.
As it presently is constructed, the contract is vulnerable to the [allowance double-spend exploit](https://github.com/comitylabs/openzeppelin-contracts/blob/6bd6b76d1156e20e45d1016f355d154141c7e5b9/contracts/token/ERC20/IERC20.sol#L43), as with other ERC20 tokens.
`GMX_REWAED_ROUTER_V2` and `GMX_REWAED_ROUTER` in`GMXV1Authorization`.
The `_allowedContractToFunctions` stores a mapping of allowed contracts and their corresponding allowed function selectors, while the `_contractACL` mapping stores target contract addresses and corresponding ACL contract addresses. One can add an address to `_contractACL` mapping via `setContractACL()`, but the function does not check if that target contract address is already in `_allowedContractToFunctions`, which is essential, as unless the contract is in that mapping, the flow will never reach the `_contractACL`.
Every Solidity file specifies in the header a version number of the format `pragma solidity (^)0.8.*`. The caret (`^`) before the version number implies an unlocked pragma, meaning that the compiler will use the specified version _and above_, hence the term "unlocked".
The report names a repository or files. Open the report to see its scope.
Repository and files the report names (36)
240 projects reviewed · 338 reports · latest Nov 2026
See Quantstamp’s auditsSomething wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.
Tell us