Solv Protocol- Vault Guardian

QuantstampRepository at commit 80300ac

Quantstamp reviewed Solv Protocol (Solv Protocol- Vault Guardian) on 25 Mar 2024: 11 findings, 0 critical; 7 marked fixed, 4 acknowledged; 1 more marked mitigated.

No open critical findings
Open the reportOpen Solv Protocol’s security record

Report hosted on certificate.quantstamp.com.

Trustblock does not review code.

Findings20

Statuses are the security firm’s own, from its report.

SeverityOpenAcknowledgedFixedMitigated
Critical0000
High0030
Medium0011
Low0430

Marked Informational by the firm. Not counted as findings.

InformationalIt Is Not Possible to Add or Remove Tokens From WhitelistAcknowledged

Currently, some of the ACL implementations that allow token whitelisting only allow them to be added via `_addTokenWhitelist()` during deployment. There is no way to modify this token whitelist following deployment. This could be an issue if one of the tokens becomes compromised or is no longer supported, or, if there are additional tokens that would want to be supported by Solv in the future.

Informational'Dead' CodeFixed

"Dead" code refers to code which is never executed and hence makes no impact on the final result of running a program. Dead code raises a concern, since either the code is unnecessary or the necessary code's results were ignored. There is dead code in the following places: 1. `ETH` in `ERC20ApproveAuthorization` 2. `ETH` in `ERC20TransferAuthorization` 3. `GLP_REWAED_ROUTER` in `GMXV1AuthorizationACL` 4. `repayWithBalance()` in `SolvOpenEndFundAuthorizationACL`

Informational`repayWithBalance()` Not Supported upon InitialzationFixed

Currently, the `SolvOpenEndFundAuthorization` does not initialize with support for the `repayWithBalance()` function despite that function being included in the `SolvOpenEndFundAuthorizationACL`.

Informational`transferGovernance()` should use 2-step processFixed

The owner of the contracts can call `transferGovernance()` to transfer the ownership to a new address. If an uncontrollable address is accidentally provided as the new owner address, then the contract will no longer have an active owner, and functions with the `onlyGovernor()` modifier can no longer be executed.

InformationalAllowance Double-Spend ExploitFixed

As it presently is constructed, the contract is vulnerable to the [allowance double-spend exploit](https://github.com/comitylabs/openzeppelin-contracts/blob/6bd6b76d1156e20e45d1016f355d154141c7e5b9/contracts/token/ERC20/IERC20.sol#L43), as with other ERC20 tokens.

InformationalCode TyposFixed

`GMX_REWAED_ROUTER_V2` and `GMX_REWAED_ROUTER` in`GMXV1Authorization`.

InformationalIt Should Not Be Possible to `setContractACL` if `_allowedContractToFunctions` Does Not Have an Entry for ContractFixed

The `_allowedContractToFunctions` stores a mapping of allowed contracts and their corresponding allowed function selectors, while the `_contractACL` mapping stores target contract addresses and corresponding ACL contract addresses. One can add an address to `_contractACL` mapping via `setContractACL()`, but the function does not check if that target contract address is already in `_allowedContractToFunctions`, which is essential, as unless the contract is in that mapping, the flow will never reach the `_contractACL`.

InformationalUnlocked PragmaFixed

Every Solidity file specifies in the header a version number of the format `pragma solidity (^)0.8.*`. The caret (`^`) before the version number implies an unlocked pragma, meaning that the compiler will use the specified version _and above_, hence the term "unlocked".

Contracts in scope

No deployed address is recorded for this audit.

The report names a repository or files. Open the report to see its scope.

Repository and files the report names (36)

  • https://github.com/solv-finance/solv-vault-guardian/src/utils/Governable.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/package.json at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/authorizations/gmxv1/GMXV1Authorization.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/test/authorizations/ERC20TransferAuthorization.t.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/authorizations/lendle/LendleAuthorizationACL.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/test/authorizations/GMXV2Authorization.t.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/test/SolvVaultGuardian.t.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/test/common/SolvVaultGuardianBaseTest.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/common/SolvVaultGuardianBase.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/authorizations/agni/AgniAuthorization.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/authorizations/ERC20TransferAuthorization.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/common/Type.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/utils/Multicall.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/remappings.txt at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/authorizations/gmxv1/GMXV1AuthorizationACL.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/authorizations/gmxv2/GMXV2AuthorizationACL.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/yarn.lock at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/hardhat.config.ts at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/LICENSE at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/common/BaseACL.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/authorizations/SolvOpenEndFundAuthorization.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/foundry.toml at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/authorizations/CoboArgusAdminAuthorization.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/libraries/BytesLib.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/.gitmodules at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/.gitignore at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/authorizations/gmxv2/GMXV2Authorization.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/common/BaseAuthorization.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/authorizations/agni/AgniAuthorizationACL.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/SolvVaultGuardianForSafe13.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/authorizations/ERC20ApproveAuthorization.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/libraries/Path.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/README.md at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/authorizations/SolvOpenEndFundAuthorizationACL.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/authorizations/lendle/LendleAuthorization.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025
  • https://github.com/solv-finance/solv-vault-guardian/src/common/FunctionAuthorization.sol at commit 80300ac901a0019448bc87b39cfebde1f27b1025

Part of Solv Protocol’s security record

Solv Protocol
Audits6 audits by 3 firmsLast audit Dec 2025, by Quantstamp.
Critical findingsNo open critical findingsAcross 6 reports.
Open Solv Protocol’s security record

Security firm

Quantstamp

240 projects reviewed · 338 reports · latest Nov 2026

See Quantstamp’s audits

Something wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.

Tell us