Part of CertiK’s series
CertiK reviewed Venus Protocol (Venus - sfrxETH oracle adapter) on 17 May 2024: 5 findings, 0 critical; 2 marked fixed, 3 open.
Report hosted on skynet.certik.com.
Trustblock does not review code.
Statuses are the security firm’s own, from its report.
| Severity | Open | Acknowledged | Fixed |
|---|---|---|---|
| Critical | 0 | 0 | 0 |
| High | 2 | 0 | 0 |
| Medium | 0 | 0 | 0 |
| Low | 1 | 0 | 2 |
In the contract `SFrxETHOracle`, the role `DEFAULT_ADMIN_ROLE` of the `AccessControlManager` can grant addresses the privilege to call the following functions: - `setMaxAllowedPriceDifference()` Any compromise to the `DEFAULT_ADMIN_ROLE` or accounts granted this privilege may allow a hacker to take advantage of this authority and do the following: - Increase or decrease the allowed price difference to cause a denial of service or enable larger price fluctuations.
`SFrxETHOracle` is an upgradeable contract, the owner can upgrade the contracts at any time. If an attacker compromises the owner, they can change the implementation of the contract to return any price they wish for the asset to steal funds from the protocol.
The `maxAllowedPriceDifference` is designed to revert cases when the difference of the two prices returned via the `SfrxEthUsdDualOracle` are greater than it. This helps mitigate issues if one oracle was to be compromised and return the wrong price. However, this value must be chosen high enough that it will not cause a denial of service due to natural discrepancies between the two oracles prices and low enough that it will not allow for a significant manipulated price to be returned.
The report names a repository or files. Open the report to see its scope.
Repository and files the report names (1)
1,045 projects reviewed · 1,376 reports · latest May 2025
See CertiK’s auditsSomething wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.
Tell us