Part of CertiK’s series
CertiK reviewed Venus Protocol (Venus - Two Kinks Interest Rate) on 31 Jul 2024: 5 findings, 0 critical; 4 marked fixed, 1 open.
Report hosted on skynet.certik.com.
Trustblock does not review code.
Statuses are the security firm’s own, from its report.
| Severity | Open | Acknowledged | Fixed |
|---|---|---|---|
| Critical | 0 | 0 | 0 |
| High | 0 | 0 | 0 |
| Medium | 0 | 0 | 0 |
| Low | 1 | 0 | 4 |
The two kink interest rate model gets the borrow rate as a piecewise linear function whose boundary points are given by kink1 and kink2. The provided documentation provided two models, one of which only included linear curves with positive slope, and the second that only allowed for a linear curve with negative slope between kink1 and kink2. However, the implementation makes no checks on any of the multipliers, so that all three linear curves of the piecewise function are allowed to have negative slope. While it may be desired to have negative slope linear curves in the intervals [0, kink1] and [kink1,kink2], the interval [kink2,1e18] has the highest utilization rates and should incentivize users to payback their borrows by having a higher borrow rate. As such the slope for the linear function in this interval should be positive to increase the borrow rates as the utilization rate closely approaches 100 percent. In addition, the utilization of negative multipliers requires the addition of some checks and castings which increase gas costs slightly. As such it may be beneficial to create two separate rate models as in the documentation. One that only allows for positive multipliers and the other which allows for desired negative multipliers. Last, it should be noted that in the case where `max(0, output)` is 0, where `output` represents one of three formulae depending on the subinterval, this may present an extra kink in the interest rate model, via a horizontal slope, until the `output` value is again positive. In this way, there may be more than two kinks in the interest rate model.
The report names a repository or files. Open the report to see its scope.
Repository and files the report names (3)
1,045 projects reviewed · 1,376 reports · latest May 2025
See CertiK’s auditsSomething wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.
Tell us