qiibee - Token Sale

The `setWinners` function in the `Raffle` contract appears to perform actions that do not align with its name. Instead of setting or recording winners, the function transfers the specified amounts from each winner's balance to the contract owner, which is misleading and can lead to confusion or misuse. ```solidity function setWinners( address[] calldata winners, uint256[] calldata amountList ) external onlyOwner returns (uint256) { require(uint64(block.timestamp) > endTime, "Raffle is still open"); require( winners.length == amountList.length, "Array lengths should match" ); uint256 amountToWithdraw = 0; for (uint16 i = 0; i < winners.length; i++) { amountToWithdraw += amountList[i]; // debit user's amount amounts[winners[i]] -= amountList[i]; } payable(owner()).transfer(amountToWithdraw); return amountToWithdraw; } ```

It is not recommended to use Solidity's `transfer()` and `send()` functions for transferring native tokens, since some contracts may not be able to receive the funds. Those functions forward only a fixed amount of gas (2300 specifically) and the receiving contracts may run out of gas before finishing the transfer. Also, EVM instructions' gas costs may increase in the future. Thus, some contracts that can receive now may stop working in the future due to the gas limitation. ```solidity=77 payable(owner()).transfer(amountToWithdraw); ``` - `Raffle.setWinners` uses `transfer()`.