Huddle01

QuillAudits11 Sep 2024Files named in the report

Audit · firm’s term: audit report

QuillAudits reviewed Huddle01 on 11 Sep 2024: 7 findings, 0 critical; 5 marked fixed, 2 open.

No open critical findings

Open the report Open Huddle01’s security record

Report hosted on quillaudits.com.

Trustblock does not review code.

Findings7

Statuses are the security firm’s own, from its report.

Severity	Open	Fixed
Critical	0	0
High	0	0
Medium	2	0
Low	0	5

LowCash event emits zero constantly for saleTokenBalanceFixed

The Cash event which gets emitted when the cashier or the contract owner invokes the cashPaymentToken function for withdrawal of the payment tokens. However, this will constantly emit 0 for the saleTokenBalance parameter in the event. There is a need to also rename the paymentTokenBalance parameter in the event to a clarified variable name since it emits the amount to be withdrawn and not the balance of payment token in the contract.

LowgetSaleTokensSold internal function was declared but unusedFixed

The purpose of the getSaleTokenSold function was to get information of how much sales token has been acquired. However, this function which has an internal visibility and made the Cashable an abstract contract, was clearly defined in the Sale contract yet it was not invoked anywhere. This was declared but left unused.

LowRemove unused state variable and modifierFixed

A variable and modifier were declared but were never used within a function.

LowState variable should be marked as constantFixed

This state variable was initialized but there are no functions to further update this variable.

LowVariable only set at the constructor should be made immutableFixed

This variable only gets set at the constructor and there is no function to update the salePrice value after deployment.