Part of Quantstamp’s series
Quantstamp reviewed Venus Protocol (Time-Based Contracts (Venus)) on 18 Mar 2024: 5 findings, 0 critical; 3 marked fixed, 2 acknowledged.
Report hosted on certificate.quantstamp.com.
Trustblock does not review code.
Statuses are the security firm’s own, from its report.
| Severity | Open | Acknowledged | Fixed |
|---|---|---|---|
| Critical | 0 | 0 | 0 |
| High | 0 | 0 | 0 |
| Medium | 0 | 0 | 0 |
| Low | 0 | 2 | 3 |
In the `setLastRewardingBlocks()` function of the `RewardsDistributor` contract, the input string to `_checkAccessAllowed()` is `setLastRewardingBlock` instead of `setLastRewardingBlocks` as the function name.
In the `_calculateNotDistributedAwards()` function of the `PoolLens` contract, the rewards are calculated based on the mode (time-based or block-based) that the reward distributor is configured. Since all the reward distributor contracts deployed on the same chain should use the same mode as `PoolLens`, consider adding a check to ensure they are in the same mode to reduce the risk of misconfiguration during contract deployment. Also, the local variable, `isTimeBased`, shadows a state variable inherited from the `TimeManagerV8`. It is generally recommended to avoid shadow variables as a best practice.
It is important to validate inputs, even if they only come from trusted addresses, to avoid human error. The following is a non-exhaustive list of missing input validations: 1. In the `SetterFacet` contract, the `_setXVSVToken()` function sets the VToken contract corresponding to the XVS token. As a best practice, there can be a check on the provided argument `xvsVToken_` to ensure that the underlying token of `xvsVToken_` matches the configured `xvs`. 2. The constructor of the VToken contract should validate that the value of `MAX_BORROW_RATE_MANTISSA` is not greater than `1e18`. 3. In the `constructor()` of the `SequencerChainlinkOracle` contract, check that sequencer is not set to the zero address.
The report names a repository or files. Open the report to see its scope.
Repository and files the report names (22)
236 projects reviewed · 332 reports · latest Oct 2026
See Quantstamp’s auditsSomething wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.
Tell us