Pablo DeFi security record

A reentrancy attack can occur when the contract creates a function that makes an external call to another untrusted contract before resolving any effects. If the attacker can control the untrusted contract, they can make a recursive call back to the original function, repeating interactions that would have otherwise not run after the external call resolved the effects. ### External call(s) ```solidity=532 PabloStake(PABLOStaking).ADDFUNDSby(feeAmount); ``` ### State variables written after the call(s) ```solidity=539 _balances[to] += value.sub(feeAmount); ```

The linked statements do not affect the functionality of the codebase and appear to be either leftovers from test code or older functionality.

State variables that never change should be declared as `constant` to save gas. ```solidity=351 uint256 public feeDenominator = 1000; ``` - `feeDenominator` should be declared `constant`.

The `SafeMath` library is used unnecessarily. With Solidity compiler versions 0.8.0 or newer, arithmetic operations will automatically revert in case of integer overflow or underflow. ```solidity=268 library SafeMath { ``` - An implementation of `SafeMath` library is found. --- ```solidity=337 using SafeMath for uint256; ``` - `SafeMath` library is used for `uint256` type in `ERC20` contract. --- ```solidity=337 using SafeMath for uint256; ``` - `SafeMath` library is used for `uint256` type in `ERC20` contract. ```solidity=524 uint256 feeAmount = value.mul(_realFee).div(feeDenominator); ``` - `SafeMath.mul` is called in `_update` function of `ERC20` contract. *Note: Only a sample of 2 `SafeMath` library usage in this contract (out of 5) are shown above.*