Saffron
Summary
The diff review of the Saffron Finance project has been conducted from commit `510c33a94c30dab7b3ec7458067ee08e60c5861c` to `223bd732088db11fecd954b16c96e7f50fc6a1d4` and has revealed a few issues that must be addressed prior to deployment. These issues included possibilities of being fron-run, missing input validation, concerns around the Solidity version, and questions about the behavior of vaults after the term is over. Overall these issues were of Low to Informational severity, but they still need to be carefully addressed and mitigated. One issue of Undetermined severity allowed a user to fron-run a lucrative vault. On the documentation front, it requires further work and needs improvement. The test quality should also be worked on, and branch coverage should be increased to `90%`. <br><p>**Fix Review**: Following the fix review, the Quantstamp team confirmed that all issues have either been fixed, mitigated, or sufficiently acknowledged for `QS-1` to `QS-12`.
Issues (12)
Low | Medium | High | Critical | Total | |
|---|---|---|---|---|---|
Not fixed | 5 | - | - | - | 5 |
Acknowledged | - | - | - | - | 0 |
Fixed | 7 | - | - | - | 7 |
| Total | 12 | 0 | 0 | 0 | 12 |