Part of Quantstamp’s series
Quantstamp reviewed Venus Protocol (Venus Income Allocation) on 12 Oct 2023: 12 findings, 0 critical; 2 marked fixed, 10 acknowledged; 2 more marked mitigated.
Report hosted on certificate.quantstamp.com.
Trustblock does not review code.
Statuses are the security firm’s own, from its report.
| Severity | Open | Acknowledged | Fixed | Mitigated |
|---|---|---|---|---|
| Critical | 0 | 0 | 0 | 0 |
| High | 0 | 0 | 0 | 0 |
| Medium | 0 | 2 | 0 | 0 |
| Low | 0 | 8 | 2 | 2 |
The firm marks these findings Mitigated. They are not counted as open, acknowledged or fixed.
It is important to validate inputs, even if they only come from trusted addresses, to avoid human error. The following functions are missing validation checks: 1. `ProtocolShareReserve` 1. `initialize()` 1. `_accessControlManager` should not be `address(0)`. 2. `_loopsLimit` should not be `0`. 2. `addOrUpdateDistributionConfigs()` 1. `configs` should have a length greater than `0`. 3. `releaseFunds()` 1. `assets` should have a length greater than `0`. 2. `Isolated Pool VToken` 1. `setReduceReservesBlockDelta()` 1. `_newReduceReservesBlockDelta` should be greater than `0`. Otherwise, this would lead to an inconsistent reduction of reserves. 2. `mint()` 1. Allows to mint based on 0 underlying tokens 3. `Core Pool VToken` 1. `setReduceReservesBlockDelta()` 1. `_newReduceReservesBlockDelta` should be greater than `0`.
The `ProtocolShareReserve.addOrUpdateDistributionConfigs()` function allows privileged roles to add or update the distribution configurations. Before these configurations are updated, the `_accrueAndReleaseFundsToPrime()` function is invoked to signal `Prime` to accrue interests. Then, `ProtocolShareReserve` transfers funds to `Prime` by invoking the `_releaseFund()` internal function with every asset in the `Prime` contract's market as an argument. According to the code comments, the accrual and release of funds to `Prime` are necessary before updating the distribution configurations. However, this design introduces a potential issue where failing to accrue and release funds to `Prime` will block the configuration updates. Additionally, during the `_releaseFund()` function call, two external calls occur: 1. Tokens are transferred from `ProtocolShareReserve` to each configured destination. 2. The `updateAssetsState()` function is called on each destination contract. If any of the external calls fails, the entire transaction fails. Failures can occur due to various reasons, including but not limited to: 1. A bug in the `Prime` contract causing the interest accrual call to fail. 2. A bug on the destination contracts causing the `updateAssetsState()` call to fail. 3. Token transfer failures to the destination contracts, which can occur due to token pausing, reverting on zero-value transfers, blacklisting of the sender or receiver, etc. In cases 1 or 2, the `Prime` or destination contracts may require fixes and/or upgrades to unblock the `addOrUpdateDistributionConfigs()` call. In case 3, a potential solution could be the `Prime` contract removing the problematic tokens from its market. However, regardless of the specific issue, the problematic configuration can block the updates of others until the issue is resolved.
The report names a repository or files. Open the report to see its scope.
Repository and files the report names (3)
240 projects reviewed · 338 reports · latest Nov 2026
See Quantstamp’s auditsSomething wrong on this page? A missing report, a wrong date, a finding that was fixed since. Tell us and we check it against its source.
Tell us